Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pytest to collect test names #3

Merged

Conversation

braingram
Copy link

@braingram braingram commented Sep 11, 2024

This PR uses a pytest hook to collect the test names and set operations to compare them to the required tests.

Comment on lines +21 to +22
missing_test_names = required_test_names - all_test_names
assert not missing_test_names, f"Missing tests {missing_test_names} required by DMS"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Owner

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I forgot that modules ARE filenames in python

@zacharyburnett zacharyburnett merged commit 82e9142 into zacharyburnett:scsb174 Sep 11, 2024
11 of 12 checks passed
@zacharyburnett zacharyburnett deleted the pytest_name_collection branch September 11, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants