Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich embeds #886

Open
sharifkhalladi opened this issue Feb 27, 2020 · 5 comments
Open

Rich embeds #886

sharifkhalladi opened this issue Feb 27, 2020 · 5 comments

Comments

@sharifkhalladi
Copy link

It would be useful to have the ability to include rich embeds without having to set up a code and render note and then using the "include note" functionality (I'm currently using this method to achieve rich media embeds, along with some minor CSS edits to hide the title of the included note).

I believe CKEditor has some native media embed capabilities but am unsure if we can simply enable these somehow.

I very much like how Outline approaches this, see an example here.

@sharifkhalladi sharifkhalladi changed the title [Feature request] (Simpler) Rich embeds [Feature Request] (Simpler) Rich embeds Feb 27, 2020
@zadam
Copy link
Owner

zadam commented Feb 28, 2020

Yes, CKEditor has rich embed. I tried it a while ago and it did not work properly, but quite possibly it has been improved since. This would have to be enabled in the CKEditor build.

However I don't know if/how this would work with e.g. Airtable. I mean I don't know if all there is to integrate it is to enable this embedding and the rest will work automagically.

@sambbaron
Copy link

sambbaron commented Apr 26, 2020

@popey456963 popey456963 changed the title [Feature Request] (Simpler) Rich embeds Rich embeds May 7, 2020
@chee
Copy link
Contributor

chee commented Apr 17, 2021

The media-embed library seems to be for embedding videos from websites like youtube. I'm primarily interested in embedding my own media, media that I have in another note. Similar to how you can see an image in the document it has been pasted into (it becomes an <img>), I'd like to be able to see included video notes become <video/> and audio become <audio/> without needing to create a render note.

Is that a new issue?

I can see that ckeditor provides a ckeditor5-image which is what you're using for this, but code for video and audio would be custom.

@zadam
Copy link
Owner

zadam commented Apr 17, 2021

Hi, notes are normally added to another note through include note but this did not render a preview. I added it now so it looks like this:

image

@chee
Copy link
Contributor

chee commented Apr 17, 2021

Hi, notes are normally added to another note through include note but this did not render a preview. I added it now so it looks like this:

image

oh!! that's so exciting! a few of my notes are about to look so good!! thank you so much 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants