Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump validator 12.2.0 → 13.6.0 to get ReDOS vulnerability fixes #265

Merged

Conversation

nvenegas
Copy link
Contributor

@nvenegas nvenegas commented May 5, 2021

@nvenegas
Copy link
Contributor Author

nvenegas commented May 5, 2021

The build in master is currently red: Build #514

Locally I get the same single failing test, and with this bump to validator I get the same single failing test

@zaggino Any tips on how to go about fixing the master build so that I can get this PR merged and released?

nvenegas added a commit to atlassian-forks/swagger-parser that referenced this pull request May 5, 2021
WIP because the earliest version of z-schema that would have the required
bump to validator is 5.0.1. See zaggino/z-schema#265
@nvenegas
Copy link
Contributor Author

nvenegas commented May 5, 2021

I'll need to consume this in https://github.com/APIDevTools/swagger-parser/ (see APIDevTools/swagger-parser#166) — are there any significant changes between 4.2.3 and 5.0.0 of z-schema? (I can't seem to find a changelog)

@zaggino
Copy link
Owner

zaggino commented May 11, 2021

@nicolasv dropped node 6 and a change in default behaviour of breakOnFirstError
v4.2.3...v5.0.0

@zaggino zaggino merged commit c703faf into zaggino:master May 11, 2021
@zaggino
Copy link
Owner

zaggino commented May 11, 2021

Published as z-schema@5.0.1

nvenegas added a commit to atlassian-forks/swagger-parser that referenced this pull request May 11, 2021
WIP because the earliest version of z-schema that would have the required
bump to validator is 5.0.1. See zaggino/z-schema#265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants