Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Commit

Permalink
PR Template
Browse files Browse the repository at this point in the history
  • Loading branch information
radekjg committed Oct 18, 2020
1 parent 2bd612b commit 270d411
Show file tree
Hide file tree
Showing 4 changed files with 696 additions and 1,535 deletions.
25 changes: 25 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
**Checklist**:

1. Code
- [ ] Finished development
- [ ] Finished unit tests (98% coverage)
- [ ] Added functional tests

2. Database
- [ ] Created database migrations
- [ ] Updated Hasura metadata
- [ ] Recreated database graph (`make graph`)

3. Verification
- [ ] Checked feature manually in browser/Postman
- [ ] Formatted code (`make format`)
- [ ] Checked code locally (`make lint test`)

4. Documentation
- [ ] Connected PR to card on Trello
- [ ] Updated `README.md`
- [ ] Updated `CHANGELOG.md`
- [ ] Updated swagger (`make openapi`)

5. Other
- [ ] Updated messages file (`make messages`) and added missing translations
5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ lint: lint-check lint-black lint-isort lint-pycodestyle lint-bandit lint-mypy li

# General

prcheck: install-dev format lint test-cov graph messages
prcheck: install-dev format lint test-cov graph messages openapi

# Docker

Expand All @@ -95,5 +95,8 @@ graph:
messages:
docker-compose exec -T web django-admin makemessages -l pl

openapi:
docker-compose exec -T web django-admin generateschema --file=docs/swagger.yaml

django:
docker-compose exec web django-admin $(cmd)
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,11 @@ Uses the default Django development server.
1. Docker
- graph - create model graph
- messages - updates translation file
- openapi - updates swagger file
- django - run django admin command (syntax: `make django cmd='migrate'`)

For example, before creating a pull requests make sure you ran locally:
`make install-dev format lint test-cov graph messages`
`make install-dev format lint test-cov graph messages openapi`
(And check if there are no missing transactions) or simply:
`make prcheck`.

Expand Down
Loading

0 comments on commit 270d411

Please sign in to comment.