don't use system jemalloc #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-rocksdb/rust-rocksdb#863 for more info.
TLDR:
before my change in a2ca8cf rust rocksdb would force rocksdb to use jemalloc when the jemalloc feature is enabled because of the use of https://github.com/zaidoon1/rust-rocksdb/blob/master/librocksdb-sys/Cargo.toml#L46 in tikv jemalloc. However, because we were not passing the right flags introduced in that commit, rocksdb didn't know that jemalloc is usable so it didn't enable various optimizations that are gated behind jemalloc being enabled and also didn't allow dump memory stats option to work. While my change fixed that and allowed rocksdb to find jemalloc and enable the optimizations, it required linux systems to install jemalloc so that rocksdb can find jemalloc. Thanks to Cristian Vîjdea we no longer need to install jemalloc on the system to have rocksdb recognize that jemalloc is installed.