Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified test #1

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

radarhere
Copy link

Suggestions for python-pillow#8350

  • If we're going to artificially create a test image, instead of doing it beforehand and adding another 54kb to the test suite, let's just create the EXIF header in code.
  • I understand you're mimicking the test code from Handle EXIF data truncated to just the header python-pillow/Pillow#6124, but that was for when the Exif data immediately stopped after the header. Your scenario is for two headers and then the rest of the data, almost the opposite of that. So I don't think we need to add a dedicated test for when there are two Exif headers and then the data stops. And rather than testing for just emptiness or not of the EXIF data, let's check one of the values inside.

@zakajd
Copy link
Owner

zakajd commented Sep 5, 2024

I like this way, let's do that. Will update PR soon

@zakajd zakajd merged commit 865a6c9 into zakajd:jamil/doubleexif Sep 6, 2024
@radarhere radarhere deleted the jamil/doubleexif branch September 6, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants