feat: create a proposal that check if features are enabled on browser #849
+213
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw an issue opened from a long time without any push .. i wanted to contribute on it.
I thinked about something like that (for this issue #746).
CheckNavigatorProvidercan be used at the top of the application. inside the for we can remove the console.error to do everything that we want !the Table will use the context to render this :
When everything is ok
When something is ok and we wan't to render something else (like a message to the user)
And this is when you have some check that fail. but without any render of messages
this is only a contribution. we can't go from that, or re-think everything !