Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client-go to v1.19.7 #142

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Update client-go to v1.19.7 #142

merged 1 commit into from
Jan 20, 2021

Conversation

mikkeloscar
Copy link
Collaborator

Early spring cleaning of es-operator:

  • Updates client-go to v1.19.7 (latest version running in Zalando clusters as of CW03)
  • Introduces CRD generation from types.go file. Enhances the CRDs with better description and it will be easier to make changes in the future.

@mikkeloscar mikkeloscar force-pushed the update-client-go-v0.19.7 branch 3 times, most recently from c339054 to 446f9a3 Compare January 19, 2021 22:46
@otrosien
Copy link
Member

E2E failing: The CustomResourceDefinition "elasticsearchdatasets.zalando.org" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[scaling].properties[diskUsagePercentScaledownWatermark].type: Required value: must not be empty for specified object fields

@mikkeloscar
Copy link
Collaborator Author

mikkeloscar commented Jan 20, 2021

@otrosien This is because we were using float64 for the diskUsagePercentScaledownWatermark which is not supported by the CRD generation tooling and is generally not well supported or recommended in Kubernetes (Example of how floats are not stable because the precision: zalando-incubator/stackset-controller#214).

I have now changed the value to int32 as I believe there is no real value in being able to define percent with float precision. All examples already use whole integers for this value.

@otrosien
Copy link
Member

apparently something changed for mandatory attributes.

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
@mikkeloscar
Copy link
Collaborator Author

@otrosien Great that we have this check to catch it :)

@mikkeloscar
Copy link
Collaborator Author

Correctly annotated the optional fields so they are optional in the CRD spec.

@mikkeloscar
Copy link
Collaborator Author

👍

1 similar comment
@otrosien
Copy link
Member

👍

@otrosien otrosien merged commit 9f6b907 into master Jan 20, 2021
@otrosien otrosien deleted the update-client-go-v0.19.7 branch January 20, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants