-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update client-go to v1.19.7 #142
Conversation
c339054
to
446f9a3
Compare
E2E failing: The CustomResourceDefinition "elasticsearchdatasets.zalando.org" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[scaling].properties[diskUsagePercentScaledownWatermark].type: Required value: must not be empty for specified object fields |
446f9a3
to
534a605
Compare
@otrosien This is because we were using I have now changed the value to |
apparently something changed for mandatory attributes. |
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
534a605
to
f4b9d2e
Compare
@otrosien Great that we have this check to catch it :) |
Correctly annotated the optional fields so they are optional in the CRD spec. |
👍 |
1 similar comment
👍 |
Early spring cleaning of es-operator:
types.go
file. Enhances the CRDs with better description and it will be easier to make changes in the future.