Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Refactor hierarchies & test-runner — for type-hinting #196

Merged
merged 3 commits into from
Oct 4, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Oct 1, 2019

Refactor hierarchies & test-runner toolkits to prepare for the overall type-hinting.

Issue : #194

Description

All the changes are done as a preparation for the throughout type-hinting in the code base. Resolving the cyclic imports becomes important. The whole refactoring is split into few PRs (one per concept) for ease of review.

Create a new group (package) of modules — toolkits — for all modules which are not directly involved in the operators functionality, but can be very helpful to ease some common tasks in those operators:

  • Object hierarchy management (ownership, labelling, naming, namespacing, etc).
  • Operator testing.

The name kopf.testing is a documented public interface, so it remains — just converted from a package to a module now.

Types of Changes

  • Refactor/improvements

There are no behavioural changes. Only the code refactoring. The tests show that all the protocols and interfaces are kept in place — except for the imports of the internal modules (not exposed via kopf/__init__.py).

@nolar nolar requested a review from samurang87 as a code owner October 1, 2019 20:07
@zincr
Copy link

zincr bot commented Oct 1, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Copy link

@jonathanbeber jonathanbeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nolar nolar merged commit ddf9260 into zalando-incubator:master Oct 4, 2019
@nolar nolar deleted the typehints-toolkits branch October 4, 2019 13:25
@nolar nolar added the refactoring Code cleanup without new features added label Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactoring Code cleanup without new features added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants