This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Refactor hierarchies & test-runner — for type-hinting #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor hierarchies & test-runner toolkits to prepare for the overall type-hinting.
Description
All the changes are done as a preparation for the throughout type-hinting in the code base. Resolving the cyclic imports becomes important. The whole refactoring is split into few PRs (one per concept) for ease of review.
Create a new group (package) of modules —
toolkits
— for all modules which are not directly involved in the operators functionality, but can be very helpful to ease some common tasks in those operators:The name
kopf.testing
is a documented public interface, so it remains — just converted from a package to a module now.Types of Changes
There are no behavioural changes. Only the code refactoring. The tests show that all the protocols and interfaces are kept in place — except for the imports of the internal modules (not exposed via
kopf/__init__.py
).