Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Assume the current object as an implicit owner for hierarchies #203

Merged
merged 4 commits into from
Oct 8, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Oct 7, 2019

Assume the currently handled object as the default owner when adopting.

Issue: closes #56

Description

Simplify the usage of hierarchy management functions to make owner optional. If not specified, the currently handler object is assumed to be the owner, or the source of name prefix and namespace.

This is not done for labels, as I am not sure that kopf.label(obj) semantically implies the label transfer from the currently handled object. The labelling remains explicit.

Types of Changes

  • New feature (non-breaking change which adds functionality)

Review

List of tasks the reviewer must do to review the PR

  • Tests
  • Documentation

@nolar nolar added the enhancement New feature or request label Oct 7, 2019
@nolar nolar requested a review from samurang87 as a code owner October 7, 2019 13:21
@nolar nolar requested a review from thilp October 7, 2019 13:21
@zincr
Copy link

zincr bot commented Oct 7, 2019

🤖 zincr found 0 problems , 1 warning

ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

@zincr
Copy link

zincr bot commented Oct 7, 2019

🤖 zincr found 1 problem , 1 warning

❌ Approvals
ℹ️ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

thilp
thilp previously approved these changes Oct 7, 2019
@nolar nolar merged commit 267e23b into zalando-incubator:master Oct 8, 2019
@nolar nolar deleted the implicit-owners branch October 8, 2019 12:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicitly guess the current object being processed
2 participants