Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipper: use amazonlinux slim again but with curl (step 1/2) #7607

Merged
merged 2 commits into from
May 31, 2024

Conversation

MustafaSaber
Copy link
Member

This change should be backward compatible since old images had both curl & wget while newer images only have curl

while it's backward compatible we still need to be cautious because this change will affect canary & main fleet

This is another attempt to deploy the slimmer image, it was tested here #7521

The other flow was reverted by #7555

It also include simple skipper changes:

diff zalando/skipper@v0.21.99...v0.21.101

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
@MustafaSaber MustafaSaber added the architectural New features and architectural changes, e.g. framework changes, migrations, rollout of new services. label May 30, 2024
@MustafaSaber MustafaSaber self-assigned this May 30, 2024
@MustafaSaber
Copy link
Member Author

old image:

➜ docker run -it --rm container-registry.zalando.net/teapot/skipper-internal:v0.21.99-931 sh
sh-5.2# wget --version
GNU Wget 1.21.3 built on linux-gnu.

-cares +digest +gpgme +https +ipv6 +iri +large-file +metalink +nls
+ntlm +opie +psl +ssl/gnutls

Wgetrc:
    /etc/wgetrc (system)
Locale:
    /usr/share/locale
Compile:
    gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC="/etc/wgetrc"
    -DLOCALEDIR="/usr/share/locale" -I. -I../lib -I../lib
    -I/usr/include/libassuan2 -I/usr/include/p11-kit-1 -DHAVE_LIBGNUTLS
    -DNDEBUG -O2 -ftree-vectorize -flto=auto -ffat-lto-objects
    -fexceptions -g -grecord-gcc-switches -pipe -Wall
    -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
    -Wp,-D_GLIBCXX_ASSERTIONS
    -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
    -fstack-protector-strong
    -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1
    -march=armv8.2-a+crypto -mtune=neoverse-n1
    -mbranch-protection=standard -fasynchronous-unwind-tables
    -fstack-clash-protection
Link:
    gcc -I/usr/include/libassuan2 -I/usr/include/p11-kit-1
    -DHAVE_LIBGNUTLS -DNDEBUG -O2 -ftree-vectorize -flto=auto
    -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall
    -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
    -Wp,-D_GLIBCXX_ASSERTIONS
    -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
    -fstack-protector-strong
    -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1
    -march=armv8.2-a+crypto -mtune=neoverse-n1
    -mbranch-protection=standard -fasynchronous-unwind-tables
    -fstack-clash-protection -Wl,-z,relro -Wl,--as-needed -Wl,-z,now
    -specs=/usr/lib/rpm/redhat/redhat-hardened-ld
    -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1
    -Wl,-dT,/builddir/build/BUILD/wget-1.21.3/.package_note-wget-1.21.3-1.amzn2023.0.3.aarch64.ld
    -lmetalink -lpcre2-8 -luuid -lidn2 -lnettle -lgnutls -lz -lpsl
    -lgpgme -lgpg-error -lassuan ../lib/libgnu.a

Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://www.gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Originally written by Hrvoje Niksic <hniksic@xemacs.org>.
Please send bug reports and questions to <bug-wget@gnu.org>.
sh-5.2# curl --version
curl 8.5.0 (aarch64-amazon-linux-gnu) libcurl/8.5.0 OpenSSL/3.0.8 zlib/1.2.11 libidn2/2.3.2 libpsl/0.21.1 (+libidn2/2.3.2) nghttp2/1.59.0
Release-Date: 2023-12-06
Protocols: file ftp ftps http https
Features: alt-svc AsynchDNS GSS-API HSTS HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz PSL SPNEGO SSL threadsafe UnixSockets
sh-5.2# exit
exit

new image:

➜ docker run -it --rm container-registry.zalando.net/teapot/skipper-internal:v0.21.101-934 "sh"
sh-5.2# wget --help
sh: wget: command not found
sh-5.2# curl --help
Usage: curl [options...] <url>
 -d, --data <data>          HTTP POST data
 -f, --fail                 Fail fast with no output on HTTP errors
 -h, --help <category>      Get help for commands
 -i, --include              Include protocol response headers in the output
 -o, --output <file>        Write to file instead of stdout
 -O, --remote-name          Write output to a file named as the remote file
 -s, --silent               Silent mode
 -T, --upload-file <file>   Transfer local FILE to destination
 -u, --user <user:password> Server user and password
 -A, --user-agent <name>    Send User-Agent <name> to server
 -v, --verbose              Make the operation more talkative
 -V, --version              Show version number and quit

This is not the full help, this menu is stripped into categories.
Use "--help category" to get an overview of all categories.
For all options use the manual or "--help all".
sh-5.2# exit
exit

@AlexanderYastrebov
Copy link
Member

👍

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
@RomanZavodskikh
Copy link
Contributor

👍

1 similar comment
@MustafaSaber
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architectural New features and architectural changes, e.g. framework changes, migrations, rollout of new services. merged/alpha merged/beta merged/kube-1.30 merged/stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants