Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flex karpenter node-pool configurations #7617

Merged
merged 1 commit into from
Oct 22, 2024
Merged

flex karpenter node-pool configurations #7617

merged 1 commit into from
Oct 22, 2024

Conversation

myaser
Copy link
Member

@myaser myaser commented Jun 3, 2024 •
edited
Loading

  • allow not specifying instance-types
  • allow custom requirements by users
  • configure the admission controller with the flags necessary for the scheduling controls feature

related to zalando-incubator/cluster-lifecycle-manager#775

@myaser myaser added the minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. label Jun 3, 2024
@myaser myaser mentioned this pull request Jun 3, 2024
Merged
@myaser myaser force-pushed the flex-karpenter-node-pool-configs branch from bd77149 to f723db0 Compare June 3, 2024 12:22
@myaser myaser force-pushed the flex-karpenter-node-pool-configs branch 2 times, most recently from 09c7c04 to 05e35f4 Compare June 6, 2024 07:06
@myaser myaser force-pushed the flex-karpenter-node-pool-configs branch from 4b00744 to 90d36f9 Compare July 9, 2024 12:01
@szuecs
Copy link
Member

szuecs commented Sep 10, 2024

Please squash rebase the commits into one to keep the history clean

@myaser myaser force-pushed the flex-karpenter-node-pool-configs branch 2 times, most recently from 6e286fe to fff60b1 Compare October 22, 2024 07:04
@myaser myaser force-pushed the flex-karpenter-node-pool-configs branch from fff60b1 to dd6020f Compare October 22, 2024 08:05
@myaser
flex karpenter node-pool configurations
e396593 
Signed-off-by: Mahmoud Gaballah <mahmoud.gaballah@zalando.de>
@myaser myaser force-pushed the flex-karpenter-node-pool-configs branch from dd6020f to e396593 Compare October 22, 2024 08:08
@mikkeloscar
Copy link
Contributor

👍

1 similar comment
@myaser
Copy link
Member Author

myaser commented Oct 22, 2024

👍🏻

@myaser myaser merged commit d3e1287 into dev Oct 22, 2024
10 checks passed
@myaser myaser deleted the flex-karpenter-node-pool-configs branch October 22, 2024 09:31
This was referenced Oct 22, 2024
Merged
Merged
@k8s-on-aws-manager-app k8s-on-aws-manager-app bot mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkeloscar mikkeloscar mikkeloscar left review comments

@demonCoder95 demonCoder95 demonCoder95 left review comments

Assignees
No one assigned
Labels
merged/alpha merged/beta merged/stable minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@myaser @szuecs @mikkeloscar @demonCoder95