Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Update filter type to allow synchronous filters #100

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

shuhei
Copy link
Contributor

@shuhei shuhei commented Jan 27, 2020

Updating ServiceClientRequestFilter type to allow synchronous filter methods. In the implementation, they can return a non-promise value as written in README and tested in the unit tests.

@shuhei
Copy link
Contributor Author

shuhei commented Jan 27, 2020

Is this a breaking change? It might be a breaking change only for users who use filters outside of the filters option.

@ruiaraujo
Copy link
Contributor

This is just a type fix.The current code already converts everything to promise during the filter chain handling.

@ruiaraujo
Copy link
Contributor

👍

@ruiaraujo
Copy link
Contributor

We should refactor that part of the code with async await and skip useless promise posting as an optimization.

@shuhei
Copy link
Contributor Author

shuhei commented Jan 28, 2020

👍

@shuhei shuhei merged commit 29822c5 into zalando-incubator:master Jan 28, 2020
@grassator
Copy link
Contributor

It think this relates to this never ending discussion about Awaited type

@shuhei
Copy link
Contributor Author

shuhei commented Feb 5, 2020

Published as 0.11.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants