This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Fix setting timing flag in client creation #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the timing flag logic so that `timing` given at the time of client creation is used as fallback in case the `timing` is not given in request parameters. Added nock as a dependency to test the logic since it requires a real `request` implementation to be called together with a client.
ruiaraujo
reviewed
Sep 5, 2019
Co-Authored-By: Rui Araújo <ruka.araujo@gmail.com>
|
👍 |
|
👍 |
1 similar comment
|
👍 |
|
👍 |
|
@shuhei Thanks a lot for the PRs. If you have an opportunity would be great to have travis CI setup with automatic NPM publish on version bump to make sure that features like this become immediately available to you and not blocked by manual publishing. If you have the time please provide your NPM username so I can add it to collaborators. Preferably send it through internal channels. |
|
@grassator Sorry for this late reply. I created an issue for automatic publish. #99 I'll contact you in an internal channel after holidays. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the timing flag logic so that
timinggiven at the time of clientcreation is used as fallback in case the
timingis not given inrequest parameters.
Added nock as a dependency to test the logic since it requires a real
requestimplementation to be called together with a client.