Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Update Strategy to the Stack #179

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Add Update Strategy to the Stack #179

merged 1 commit into from
Dec 16, 2019

Conversation

arjunrn
Copy link
Contributor

@arjunrn arjunrn commented Dec 12, 2019

This PR adds UpdateStrategy to the StackSpec which means an update strategy can be specified as part of the stack template which will be propagated to the deployment.

@coveralls
Copy link

coveralls commented Dec 12, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1325

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 69.965%
Totals Coverage Status
Change from base Build 1313: 0.1%
Covered Lines: 1591
Relevant Lines: 2274
💛 - Coveralls

@arjunrn arjunrn force-pushed the update-strategy branch 2 times, most recently from 153051a to a3f5105 Compare December 12, 2019 12:28
@arjunrn arjunrn changed the title [WIP] Add Update Strategy to the Stack Add Update Strategy to the Stack Dec 12, 2019
@arjunrn
Add update strategy to the Stack
e732f30 
Signed-off-by: Arjun Naik <arjun@arjunnaik.in>
@mikkeloscar
Copy link
Contributor

👍

1 similar comment
@aermakov-zalando
Copy link
Contributor

👍

@arjunrn arjunrn merged commit b046043 into master Dec 16, 2019
@arjunrn arjunrn deleted the update-strategy branch December 16, 2019 08:37
@arjunrn arjunrn mentioned this pull request Dec 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkeloscar mikkeloscar mikkeloscar left review comments

@szuecs szuecs Awaiting requested review from szuecs

@aermakov-zalando aermakov-zalando Awaiting requested review from aermakov-zalando

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arjunrn @coveralls @mikkeloscar @aermakov-zalando