Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status should not be required in CRD #238

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Status should not be required in CRD #238

merged 1 commit into from
Aug 20, 2020

Conversation

mikkeloscar
Copy link
Contributor

@mikkeloscar mikkeloscar commented Aug 19, 2020 •
edited
Loading

Was previously fixed in #211 but forgot to remove it in #182

@mikkeloscar
Status should not be required in CRD
5e9c7aa 
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1626

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.653%
Totals Coverage Status
Change from base Build 1623: 0.0%
Covered Lines: 1544
Relevant Lines: 2249
💛 - Coveralls

@mikkeloscar
Copy link
Contributor Author

👍

1 similar comment
@gargravarr
Copy link
Contributor

👍

@gargravarr gargravarr merged commit 913fb64 into master Aug 20, 2020
@gargravarr gargravarr deleted the status-not-required-crd branch August 20, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikkeloscar @coveralls @gargravarr