Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pushing tags: overwrite if tag already exists #55

Merged
merged 1 commit into from
May 3, 2019

Conversation

tortila
Copy link
Contributor

@tortila tortila commented May 3, 2019

Signed-off-by: Oliwia Zaremba oliwia.zaremba@zalando.de

No functional changes!

Post-fix to #50

Description

This PR aims to fix the error on Travis (as seen here) where git tag fails because: fatal: tag 'v1.2.2' already exists

Types of Changes

  • Configuration change

Review

Reviewers' checklist:

  • If this PR implements new flows or changes existing ones, are there
    good tests for these flows?
    If this PR rather removes flows, are the obsolete tests removed as well?
  • Is the documentation still up-to-date and exhaustive? This covers both
    technical (in source files) and functional (under docs/) documentation.
  • Is the changelog updated?
  • Does the new version number correspond to the actual changes from this PR?
    In doubt, refer to https://semver.org.

After this PR

Check if build on Travis passes and the tag v1.2.3 is created and visible on GitHub.

Signed-off-by: Oliwia Zaremba <oliwia.zaremba@zalando.de>
@tortila tortila requested review from bmaher and thilp as code owners May 3, 2019 14:08
@zincr
Copy link

zincr bot commented May 3, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@tortila tortila merged commit 409f5ab into master May 3, 2019
@tortila tortila deleted the fix-pushing-tags branch May 3, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants