Dependency on patched jackson-json-reference

[nmcb]

Currently we depend on a patched version of jackson-json-reference. A PR has been submitted for the original library, awaiting the request, this patched version should become part of our codebase (investigate licences) or depend on it explicitly. As a workaround the artefact is currently served from bint-tray.

[benmccann]

New PR is here: AndersDJohnson/jackson-json-reference#15

[AndersDJohnson]

@nmcb @slavaschmidt @benmccann Thanks for using my jackson-json-reference library! I'm close to accepting the PR. Can I see where you're using it?

[slavaschmidt]

@adjohnson916 Thanks for looking in our PR! We rely on the library to inline references defined in Swagger library before converting it into a type-safe model. It's used here : https://github.com/zalando/play-swagger/blob/newnaming/compiler/src/main/scala/de/zalando/swagger/StrictParser.scala

[AndersDJohnson]

I've merged AndersDJohnson/jackson-json-reference#15. May release with a new version soon - let me know on that PR if that's important to you, and/or watch my repo for updates.

[AndersDJohnson]

@nmcb @slavaschmidt @benmccann See AndersDJohnson/jackson-json-reference#20 for a change to the nested dereferencing - please let me know if it works for you. If it does, I'll push a new version to Bintray so you can depend on it.

[slavaschmidt]

@adjohnson916 unfortunately id does not. The problem is, that referenced files parsed as JSON instead of YAML.
Could you please take a look? Thanks!

[AndersDJohnson]

@mcb @slavaschmidt @benmccann Please consider starring adjohnson916/jackson-json-reference to indicate that you use & like it, so we know to continue to prioritize it for support in the future.

@slavaschmidt and I are close to a resolution on the changes you needed (#15, #20), then I'll push up a new version, and consider releasing on Maven Central instead of just my personal Bintray repo.

[slavaschmidt]

Placed version 0.2.1 into the calando's bintray until public stable version of the library is available.

[AndersDJohnson]

@slavaschmidt jackson-json-reference 0.2.0 at least should be available now - see AndersDJohnson/jackson-json-reference#22.

[slavaschmidt]

@adjohnson916 do you have any plans to publish it in some of global repositories?

[AndersDJohnson]

@slavaschmidt You mean like Bintray JCenter or Maven Central?

[slavaschmidt]

exactly

[AndersDJohnson]

@slavaschmidt I've submitted a request for it to be included in JCenter on Bintray. I'll let you know if I find out that it goes through.

[slavaschmidt]

@adjohnson916 That's really great. I'd really love it to happen. Please keep me updated.

[AndersDJohnson]

@slavaschmidt So me.andrz.jackson:jackson-json-reference-core:0.2.0 should be available on JCenter now (https://bintray.com/adjohnson916/maven/jackson-json-reference-core). Let me know if you have issues.

[slavaschmidt]

@adjohnson916 Thanks for putting it into the JCenter!

It seems that to be usable, the parent needs to be available as well, here is the SBT log:

[warn] io problem while parsing ivy file: https://jcenter.bintray.com/me/andrz/jackson/jackson-json-reference-core/0.2.0/jackson-json-reference-core-0.2.0.pom: Impossible to load parent for file:/Users/slasch/.ivy2/cache/me.andrz.jackson/jackson-json-reference-core/ivy-0.2.0.xml.original. Parent=me.andrz.jackson#jackson-json-reference;0.2.0
[warn]  module not found: me.andrz.jackson#jackson-json-reference-core;0.2.0
[warn] ==== local: tried
[warn]   /Users/slasch/.ivy2/local/me.andrz.jackson/jackson-json-reference/0.2.0/ivys/ivy.xml
[warn] ==== jcenter: tried
[warn]   https://jcenter.bintray.com/me/andrz/jackson/jackson-json-reference/0.2.0/jackson-json-reference-0.2.0.pom
[warn] ==== public: tried
[warn]   https://repo1.maven.org/maven2/me/andrz/jackson/jackson-json-reference-core/0.2.0/jackson-json-reference-core-0.2.0.pom
[warn] ==== Bintray-Resolve-zalando-sbt-plugins: tried
[warn]   https://dl.bintray.com/content/zalando/sbt-plugins/me/andrz/jackson/jackson-json-reference-core/0.2.0/jackson-json-reference-core-0.2.0.pom
[warn] ==== scalaz-bintray: tried
[warn]   https://dl.bintray.com/scalaz/releases/me/andrz/jackson/jackson-json-reference-core/0.2.0/jackson-json-reference-core-0.2.0.pom
[warn] ==== zalando-maven: tried
[warn]   https://dl.bintray.com/zalando/maven/me/andrz/jackson/jackson-json-reference-core/0.2.0/jackson-json-reference-core-0.2.0.pom
[warn] ==== bintray-zalando-sbt-plugins: tried
[warn]   https://dl.bintray.com/zalando/sbt-plugins/me/andrz/jackson/jackson-json-reference-core/0.2.0/jackson-json-reference-core-0.2.0.pom
[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  ::          UNRESOLVED DEPENDENCIES         ::
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  :: me.andrz.jackson#jackson-json-reference-core;0.2.0: not found
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn]  Note: Unresolved dependencies path:
[warn]      me.andrz.jackson:jackson-json-reference-core:0.2.0 (/Users/slasch/work/workspaces/zalando/play-swagger/build.sbt#L37)
[warn]        +- de.zalando:play-swagger-compiler_2.10:0.1.8

[AndersDJohnson]

@slavaschmidt Oh it needs to resolve the parent project? That's unfortunate. JCenter denied my publishing of the parent because it didn't have its own JAR file. I have a support request into them for that. I guess you'll still have to point to my personal Bintray repo until it's resolved. I'll keep you updated.

[slavaschmidt]

@adjohnson916 thanks a lot for your support!

[AndersDJohnson]

@slavaschmidt @benmccann @nmcb FYI jackson-json-reference version 0.2.1 is now available on Maven Central, thanks to AndersDJohnson/jackson-json-reference#25.