This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Optional flag for failing on modified code tree #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrhassan
force-pushed
the
fail-on-modified
branch
from
0670f24
to
3c810d8
Compare
|
Thanks for the PR! |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an optional boolean flag
--fail-on-modifiedto make the script fail with a non-zero exit status in the case of dirty code tree. Current behaviour is still intact if the flag is not passed.I've also fixed a flake8 issue in
setup.pybecause it failed the test on Travis.Closes #9