#489 allow enabling introspection for planb-tokeninfo service #490
Conversation
|
Do you intend to have default values for this, or is this something that will only be configured per-stack? |
|
This is something that should be possible for end-users to enable in the ENVIRONMENT section of the Taupage config, so that it propagates to tokeninfo on start. Actually, we're going to need to have False as default. |
|
The question was more about whether we should enable it by default or not. |
|
Default should be false, with ability to override it to true. |
|
LGTM then. Would you mind testing this with the Dev taupage channel once we merge this, with all 3 possible values (missing/false/true)? |
|
👍 |
|
PR implementation will break existing apps, need to implement proper validation before propagation. |
|
Tested by manually applying changes to running image. Seems to work just fine. Will test dev image after merge. |
|
👍 |
1 similar comment
|
👍 |
aermakov-zalando
deleted the
feature/489-enable-introspection-passthrough
branch
Local planb-tokeninfo service takes into account ENABLE_INTROSPECTION environment variable. However currently there is no way for users to override it (taupage config variable doesn't get propagated to the startup script).