This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
#489 make taupage config option naming consistent #494
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,7 @@ script | |||
| export OPENID_PROVIDER_CONFIGURATION_URL="$config_openid_provider_configuration_url" | |||
| export REVOCATION_PROVIDER_URL="$config_revocation_provider_url" | |||
| export BUSINESS_PARTNERS="$config_tokeninfo_business_partners" | |||
| if [ "$config_tokeninfo_introspection" = "true" ] || [ "$config_tokeninfo_introspection" = "True" ]; then | |||
| if [ "$config_planb_local_tokeninfo_introspection" = "true" ] || [ "$config_planb_local_tokeninfo_introspection" = "True" ]; then | |||
There was a problem hiding this comment.
with the config be named planb_local_tokeninfo_introspection? For consistency shouldnt it be local_planb_tokeninfo_introspection
There was a problem hiding this comment.
iMO it should be local_planb_tokeninfo: true and local_planb_tokeninfo_introspection: true, yes
…pection, remove faulty support
smirnov
force-pushed
the
feature/489-rename-introspection-parameter
branch
from
9a6adf7
to
4709979
Compare
|
👍 |
1 similar comment
|
👍 |
|
Is this option documented on http://stups.readthedocs.io ? |
|
No and neither is local_planb_tokeninfo. This can and probably should be tackled together. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for enabling introspection, remove faulty support