Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

add exception class and line number #310

Merged
merged 2 commits into from
Jan 24, 2018
Merged

add exception class and line number #310

merged 2 commits into from
Jan 24, 2018

Conversation

vetinari
Copy link
Contributor

@vetinari vetinari commented Jan 24, 2018

to exceptions for checks and alerts. This way we get a better message
for the users, e.g. a

KeyError line 4: 'foo'

instead of just

'foo'

to exceptions for checks and alerts. This way we get a better message
for the users, e.g. a

    "KeyError line 4: 'foo'"

instead of just

    "foo"
@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #310 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   75.61%   75.62%   +<.01%     
==========================================
  Files          78       78              
  Lines        5447     5452       +5     
==========================================
+ Hits         4119     4123       +4     
- Misses       1328     1329       +1
Impacted Files Coverage Δ
zmon_worker_monitor/zmon_worker/tasks/main.py 76.16% <83.33%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4865cbc...3488c4f. Read the comment docs.

@vetinari
Copy link
Contributor Author

👍

@aermakov-zalando
Copy link
Contributor

🎉

@aermakov-zalando
Copy link
Contributor

Is it possible to add a note about the exception source as well, e.g. KeyError check line 20?

@mohabusama
Copy link
Contributor

@aermakov-zalando Full stacktrace in the works 😉

@vetinari
Copy link
Contributor Author

👍

1 similar comment
@mohabusama
Copy link
Contributor

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants