Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Remove breakpoint-sass dependency #129

Closed
rbarilani opened this issue Feb 19, 2016 · 0 comments
Closed

Remove breakpoint-sass dependency #129

rbarilani opened this issue Feb 19, 2016 · 0 comments
Labels
enhancement task

Comments

@rbarilani
Copy link
Contributor

Removing the breakpoint-sass will simplify the build system and the package manager support.
Right now we have to maintain a "freaky" build process to allow bower and npm to work.
The freaky part is required just because we include the breakpoint-sass dep.

My proposal is to remove the hardcoded dependency and explain in the HOW TO SASS section that the breakpoint-sass library must be included/loaded dress-code. (with compass for example is just a plugin).

SASS users can do something like...

@import "my-vendor-package-manager-folder/breakpoint-sass/whatever.scss"
@import "my-vendor-package-manager-folder/dress-code/dist/sass/dress-code.scss"
@include dc-everything

Just by adding a line for advanced users, we can remove the necessity to have a separate bower repo, we can remove freaky building tasks, we can support npm 3 and node 4.

This will not affect the generation of the distribution css, we will use breakpoint-sass just when building those artifacts and for the demo/doc site!!!
@rbarilani rbarilani mentioned this issue Feb 19, 2016
Merged
rbarilani added a commit that referenced this issue Feb 19, 2016
@rbarilani
chore(breakpoint-sass): removes breakpoint-sass dep, remove bower bui…
017ab18 
…ld, removing vendors file #129

BREAKING CHANGE: breakpoint-sass dep was removed, you hae to include that by your own, bower specific dristribution doesn't exist anymore

replace this:

```scss
@import "bower_components/dress-code/sass/dress-code"
@include dc-everything
```

with:

```scss
@import "bower_components/compass-breakpoint/stylesheets/breakpoint" // import required breakpoint sass module/plugin
@import "bower_components/dress-code/dist/sass/dress-code"
@include dc-everything;
```
rbarilani added a commit that referenced this issue Feb 19, 2016
@rbarilani
chore(node4): test build on node 4.0.0 #129
2ba7055
@rbarilani rbarilani mentioned this issue Feb 19, 2016
Merged
@rbarilani rbarilani mentioned this issue Mar 14, 2016
Closed
rbarilani added a commit that referenced this issue Mar 14, 2016
@rbarilani
Merge branch 'develop' into topic/fix-controversial-bem-110
b4ac60c 
* develop:
  fix(dialog): make dialog scrollable when hovering outside of it #142
  chore(node4): test build on node 4.0.0 #129
  fix
  chore(breakpoint-sass): removes breakpoint-sass dep, remove bower build, removing vendors file #129
  fix: change dc-dialog overlay mixin name to be consistent with the global selector one #130
  feature(icon button): Order icon button content by BEM
gabrielhl pushed a commit that referenced this issue Mar 23, 2016
@rbarilani @gabrielhl
chore(breakpoint-sass): removes breakpoint-sass dep, remove bower bui…
b73f2f1 
…ld, removing vendors file #129

BREAKING CHANGE: breakpoint-sass dep was removed, you hae to include that by your own, bower specific dristribution doesn't exist anymore

replace this:

```scss
@import "bower_components/dress-code/sass/dress-code"
@include dc-everything
```

with:

```scss
@import "bower_components/compass-breakpoint/stylesheets/breakpoint" // import required breakpoint sass module/plugin
@import "bower_components/dress-code/dist/sass/dress-code"
@include dc-everything;
```
gabrielhl pushed a commit that referenced this issue Mar 23, 2016
@rbarilani @gabrielhl
chore(node4): test build on node 4.0.0 #129
22e532d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rbarilani