Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Update readme to include tips for font size #140

Closed
cjhowald opened this issue Mar 3, 2016 · 3 comments
Closed

Update readme to include tips for font size #140

cjhowald opened this issue Mar 3, 2016 · 3 comments
Labels
Milestone

Comments

@cjhowald
Copy link
Contributor

cjhowald commented Mar 3, 2016

Right now, to achieve proper sizing, the <html> and <body> tags have to have classes dc-html and dc-body applied, respectively. We should add this to the usage steps.

@mrac
Copy link

mrac commented Mar 3, 2016

+1

@rbarilani
Copy link
Contributor

Yep we should fix that... if we cannot remove this mandatory step... what do you think if we adopt a pragmatic applying directly the mixins to html and body tag? @cjhowald @mrac

p.s. I talk to @xonic (thomas) before my holidays and it seems the dc-html mixin is really required and must be applied to the html tag. The dc-body mixin instead could be applied to every container element.

@rbarilani rbarilani added the docs label Mar 14, 2016
@rbarilani rbarilani added this to the 1.0.0-beta milestone Mar 14, 2016
rbarilani added a commit that referenced this issue Mar 15, 2016
…apply style directly on html and body because they are in any case required

	BREAKING CHANGE: .dc-html and .dc-body classes were removed.

	If you @include dc-typography-selectors (already included when import dress-code and @include dc-everything)
	you don't need anymore to use dc-html and dc-body classes, style is already applied to html and body.
rbarilani added a commit that referenced this issue Mar 15, 2016
…pply style directly on html and body because they are in any case required

	BREAKING CHANGE: .dc-html and .dc-body classes were removed.

	If you @include dc-typography-selectors (already included when import dress-code and @include dc-everything)
	you don't need anymore to use dc-html and dc-body classes, style is already applied to html and body.
rbarilani added a commit that referenced this issue Mar 21, 2016
…pply style directly on html and body because they are in any case required

	BREAKING CHANGE: .dc-html and .dc-body classes were removed.

	If you @include dc-typography-selectors (already included when import dress-code and @include dc-everything)
	you don't need anymore to use dc-html and dc-body classes, style is already applied to html and body.
rbarilani added a commit that referenced this issue Mar 21, 2016
refactor(typography): solve #140, remove .dc-html .dc-body classes...
@rbarilani
Copy link
Contributor

This will be solved with 1.0.0 beta, the fix is already merged in the 1.0.0 beta branch.

gabrielhl pushed a commit that referenced this issue Mar 23, 2016
…pply style directly on html and body because they are in any case required

	BREAKING CHANGE: .dc-html and .dc-body classes were removed.

	If you @include dc-typography-selectors (already included when import dress-code and @include dc-everything)
	you don't need anymore to use dc-html and dc-body classes, style is already applied to html and body.
rbarilani added a commit that referenced this issue Mar 23, 2016
* develop:
  docs(demo): adjust margin-botton for the dropdown button
  feat(table): Add compatibility btwn table and atoms. Close #90
  fix(demo-dialog): fix dialog preview, broken after IE fix pull request was merged, see #156
  style(input-group): remove commented out property #101
  style(tooltip): add IE 10-fix comment  #102
  fix(select): Fix select for IE. Close #99
  chore(gulp): reorder require statements
  chore(gulp): remove unused dev deps, add dependencies badges, fix license filed in the package.json
  fix(table): Fix table for IE. Close #100
  fix(inputs): Fix input groups for IE. Close #101
  refactor(typography): solve #140, remove .dc-html .dc-body classes, apply style directly on html and body because they are in any case required
  fix(tooltip): Fix tooltip for IE. Close #102
  fix(icons): Fix icon font for IE. Close #98
  chore(release): 1.3.0-alpha
  fix(tooltip): Fix tooltip display for small elements. Close #150
  feat(icons): Add drag icon
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants