Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include zalando loogbook dependencies in logbook-bom #1086

Closed
hackmann opened this issue Jul 5, 2021 · 1 comment · Fixed by #1160
Closed

Only include zalando loogbook dependencies in logbook-bom #1086

hackmann opened this issue Jul 5, 2021 · 1 comment · Fixed by #1160

Comments

@hackmann
Copy link

hackmann commented Jul 5, 2021

logbook-bom includes many test dependencies. See https://mvnrepository.com/artifact/org.zalando/logbook-bom/2.11.0

Description

Because logbook-bom has a parent module and this parent has dependency management too, these dependencies are added to the project when importing dependencies using logbook-bom

Expected Behavior

That logbook-bom does not inherit dependency management from any parent project

Actual Behavior

That logbook-bom has logbook-parent as parent which includes dependencyManagement

Possible Fix

Steps to Reproduce

Run:

mvn -Dartifact=org.zalando:logbook-bom:2.11.0 help:effective-pom 

Context

I had to create my own logbook-bom without a parent

Your Environment

  • Version used: 2.9.0 and 2.11.0
@hackmann hackmann added the Bug label Jul 5, 2021
@whiskeysierra
Copy link
Collaborator

Very good observation! Care to create a pull request?

whiskeysierra pushed a commit that referenced this issue Sep 27, 2021
* Only include zalando loogbook dependencies in logbook-bom (#1086)

* Set version of kotlin-maven-plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants