Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncDispatchTest is flaky #672

Closed
whiskeysierra opened this issue Dec 18, 2019 · 0 comments · Fixed by #680
Closed

AsyncDispatchTest is flaky #672

whiskeysierra opened this issue Dec 18, 2019 · 0 comments · Fixed by #680
Labels
Bug

Comments

@whiskeysierra
Copy link
Collaborator

Description

Expected Behavior

Test should either pass all the time or never, but not sometimes.

Actual Behavior

See https://github.com/zalando/logbook/commit/6535b6a7106b6c9271fcd4fb08fea0156fe260c4/checks?check_suite_id=363265378

Possible Fix

After receiving the response we need to wait since the servlet filter is logging the response after it has been send to the client already.

Steps to Reproduce

  1. Run test in a loop until it fails

Context

Stable build

Your Environment

  • Version used: 2.0.0-RC.7
whiskeysierra added a commit that referenced this issue Jan 6, 2020
@whiskeysierra
Fixed flaky test
7218fac 
Fixes #672
Fixes #676
@whiskeysierra whiskeysierra mentioned this issue Jan 6, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed flaky test zalando/logbook
1 participant
@whiskeysierra