Missing setter for FormRequestMode in compiled/released JAR

[jpmaas]

Description

I upgraded the dependency logbook-spring-boot-starter to the latest version (2.1.2). When I wanted to set the formRequestMode via logbook.filter.form-request-mode, I was greeted with the following message on startup:

***************************
APPLICATION FAILED TO START
***************************

Description:

Failed to bind properties under 'logbook.filter' to org.zalando.logbook.autoconfigure.LogbookProperties$Filter:

    Property: logbook.filter.form-request-mode
    Value: parameter
    Origin: class path resource [application.yml]:76:29
    Reason: No setter found for property: form-request-mode

I was a little confused since the code contains a @Setter lombok annotation. But checking the decompiled class code shows the following:

public final class LogbookProperties {

[...]

    public static class Filter {
        private final FormRequestMode formRequestMode = FormRequestMode.fromProperties();

        public Filter() {
        }

        @Generated
        public FormRequestMode getFormRequestMode() {
            return this.formRequestMode;
        }
    }
}

Turns out, the setter is actually missing.

Expected Behavior

• Lombok setter annotation is processed correctly
• configuration works as intended

Actual Behavior

• configuring the form-request-mode results in the application not starting up.

Possible Fix

Remove final from the respective variable.

Steps to Reproduce

1. Use dependency of logbook-spring-boot-starter in version 2.1.2
2. Configure logbook.filter.form-request-mode
3. Try to start spring boot application.
4. Application does not start.

Your Environment

• Version used: 2.1.2

[jpmaas]

Appended a PR for the fix. Feel free to merge.

[whiskeysierra]

Appended a PR for the fix. Feel free to merge.

PR is in the wrong repo. Happy to merge if you open it here 😉

[jpmaas]

Should be correct now, used to old bitbucket UI and github confused me with its defaults :D