Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache http client 5 #1058

Merged

Conversation

sokomishalov
Copy link
Contributor

@sokomishalov sokomishalov commented Jun 9, 2021

Original issue: #1008
P.S. Reactive adapter hasn't been implemented yet

@sokomishalov sokomishalov force-pushed the feature/apache-httpclient-5 branch 25 times, most recently from f236ed6 to 7a765fd Compare June 11, 2021 14:22
@sokomishalov sokomishalov marked this pull request as ready for review June 11, 2021 14:22
@sokomishalov sokomishalov force-pushed the feature/apache-httpclient-5 branch from 7a765fd to 8df2db2 Compare June 11, 2021 14:34
@sokomishalov sokomishalov force-pushed the feature/apache-httpclient-5 branch from 8df2db2 to 580344b Compare June 11, 2021 14:47
@whiskeysierra
Copy link
Collaborator

@sokomishalov Looks good, it's just one failing test left.

@sokomishalov sokomishalov force-pushed the feature/apache-httpclient-5 branch 10 times, most recently from c7d371c to dcb2312 Compare June 17, 2021 11:38
@sokomishalov sokomishalov force-pushed the feature/apache-httpclient-5 branch from dcb2312 to 633bcf8 Compare June 17, 2021 11:49
@sokomishalov
Copy link
Contributor Author

@whiskeysierra I've fixed the test and rebased on main branch

@whiskeysierra
Copy link
Collaborator

👍

@whiskeysierra whiskeysierra merged commit 7fd7635 into zalando:main Jun 17, 2021
@whiskeysierra
Copy link
Collaborator

@sokomishalov Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants