Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logbook-ktor modules #1105

Merged
merged 1 commit into from
Aug 17, 2021
Merged

logbook-ktor modules #1105

merged 1 commit into from
Aug 17, 2021

Conversation

sokomishalov
Copy link
Contributor

@sokomishalov sokomishalov commented Aug 6, 2021 •
edited
Loading

Description

Client and server ktor modules

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@whiskeysierra
Copy link
Collaborator

@sokomishalov 📣 Thank you for your contribution! I'm really looking forward to this!

If you can take another look at this failing test case, we can get this merged and released soon.

@sokomishalov sokomishalov force-pushed the feature/logbook-ktor branch 12 times, most recently from 5c8d2cc to e24fbdf Compare August 10, 2021 21:34
@sokomishalov sokomishalov marked this pull request as ready for review August 10, 2021 21:38
@sokomishalov
Copy link
Contributor Author

sokomishalov commented Aug 10, 2021 •
edited
Loading

I've finally fixed those failing tests and made some API cleanup.
My main concern is - should we split this module on client and server side? Each of them requires its own non-tiny dep (ktor-client-core-jvm ~630kb, ktor-server-core ~780kb).
Pros - modularity and lightweight, cons - common @ExperimentalLogbookKtorApi and convenient base integration test.

@sokomishalov sokomishalov force-pushed the feature/logbook-ktor branch 12 times, most recently from 0c0de96 to 9a38a9c Compare August 11, 2021 15:16
@sokomishalov sokomishalov force-pushed the feature/logbook-ktor branch 20 times, most recently from 274802c to 260ea27 Compare August 16, 2021 17:13
@sokomishalov
Copy link
Contributor Author

sokomishalov commented Aug 16, 2021 •
edited
Loading

@whiskeysierra Finally it's done and ready for review

@sokomishalov sokomishalov changed the title logbook-ktor module logbook-ktor modules Aug 16, 2021
@whiskeysierra
Copy link
Collaborator

👍

@whiskeysierra whiskeysierra merged commit 8332ed1 into zalando:main Aug 17, 2021
@whiskeysierra
Copy link
Collaborator

Looks great! 📣 Thanks for your contribution! Much appreciated! 🎉

I'll try to create a new release later today.

@sokomishalov sokomishalov deleted the feature/logbook-ktor branch August 17, 2021 07:32
@sokomishalov
Copy link
Contributor Author

@whiskeysierra Please take a look at a bug-fix and test-fix PR for ktor before release.

@whiskeysierra
Copy link
Collaborator

I'll create a follow-up, bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderYastrebov AlexanderYastrebov Awaiting requested review from AlexanderYastrebov

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando lukasniemeier-zalando is a code owner

@whiskeysierra whiskeysierra Awaiting requested review from whiskeysierra whiskeysierra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokomishalov @whiskeysierra