Fix for #1868 - make State subclasses real classes #1869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make State subclasses real classes (not objects, i.e. singletons) so that each request and response can have their own state instance
Description
State subclasses are
object
s which make them singletons. Hence, all requests and responses share the same state instance. I think the subclasses should beclass
es, so that requests and responses have their ownState
instances.Motivation and Context
Please see #1868
Types of changes
Checklist: