Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1868 - make State subclasses real classes #1869

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

noffke
Copy link
Contributor

@noffke noffke commented Jul 10, 2024

make State subclasses real classes (not objects, i.e. singletons) so that each request and response can have their own state instance

Description

State subclasses are objects which make them singletons. Hence, all requests and responses share the same state instance. I think the subclasses should be classes, so that requests and responses have their own State instances.

Motivation and Context

Please see #1868

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ ?] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have added tests to cover my changes.

…s, i.e. singletons) so that each request and response can have their own state instance
@kasmarian kasmarian added the bugfix Bug fixes and patches label Sep 12, 2024
@kasmarian kasmarian merged commit 812b42b into zalando:main Sep 12, 2024
4 of 5 checks passed
@kasmarian
Copy link
Member

Thank you for the fix, @noffke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes and patches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants