Update isFormRequest condition #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whiskeysierra
requested review from
AlexanderYastrebov and
lukasniemeier-zalando
| // package private so we can trick code coverage | ||
| } | ||
|
|
||
| @SneakyThrows(MimeTypeParseException.class) |
There was a problem hiding this comment.
I am not sure it is a good idea to fail in case of invalid content type. Should it return Optional<MimeType> instead?
| } | ||
|
|
||
| return false; | ||
| return contentType != null && MimeTypes.parse(contentType) |
There was a problem hiding this comment.
You could do Optional.ofNullable(contentType).map(MimeTypes::parse) as well
There was a problem hiding this comment.
🤦♂️ right...
|
|
||
| final class MimeTypesTest { | ||
|
|
||
| @Test | ||
| void shouldFailToParse() { | ||
| assertThrows(MimeTypeParseException.class, () -> MimeTypes.parse("")); | ||
| assertEquals(MimeTypes.parse(""), Optional.empty()); |
There was a problem hiding this comment.
The happy case is tested within the interceptor test
|
👍 I guess |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #208