Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made JSON heuristic handle whitespace around structural characters correctly #307

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

whiskeysierra
Copy link
Collaborator

Description

The JSON heuristic doesn't recognize {}\n as valid JSON.

Motivation and Context

JSON generators that produce formatted JSON will most likely append a trailing new line. The inlining of JSON bodies doesn't work for those.

Insignificant whitespace is allowed before or after any of the six
structural characters.

https://tools.ietf.org/html/rfc4627#section-2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@lerovitch
Copy link

👍

@whiskeysierra whiskeysierra merged commit 60c655f into master Jul 5, 2018
@whiskeysierra whiskeysierra deleted the bugfix/json-heuristic branch July 5, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants