Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests will now contain an absolute request uri #34

Merged
merged 2 commits into from
Dec 4, 2015
Merged

Requests will now contain an absolute request uri #34

merged 2 commits into from
Dec 4, 2015

Conversation

whiskeysierra
Copy link
Collaborator

This fixes #30

@lukasniemeier
Copy link

👍

@whiskeysierra
Copy link
Collaborator Author

For the servlet filter this is easy, as it provides HttpServletRequest.getRequestURL.
The HTTP Client on the other hand unfortunately wraps the request inside an HttpRequestWrapper which rewrites the URI to / (or whatever the path was).

@whiskeysierra
Copy link
Collaborator Author

I modified it again and even though it's pretty ugly it should work now.

@whiskeysierra
Copy link
Collaborator Author

@lukasniemeier Should we have both versions available, fully qualified vs. path?

@whiskeysierra
Copy link
Collaborator Author

@lukasniemeier Should we have both versions available, fully qualified vs. path?

I'll merge this now. If we decide to do that I'm going to open another issue/pull-request.

whiskeysierra added a commit that referenced this pull request Dec 4, 2015
Requests will now contain an absolute request uri
@whiskeysierra whiskeysierra merged commit d6b54b3 into zalando:master Dec 4, 2015
@whiskeysierra whiskeysierra deleted the feature/absolute-request-url branch December 4, 2015 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log full URI on request
2 participants