Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remove query filter #367

Merged
merged 2 commits into from
Oct 15, 2018

Conversation

nsmolenskii
Copy link
Contributor

Description

Add query filter, that allows removing some query parameters

Motivation and Context

Support removing some redundant query parameters:

  • too verbose names
  • too few meaning
  • debug params

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@@ -33,4 +32,10 @@ public static QueryFilter replaceQuery(final String name, final String replaceme
return query -> pattern.matcher(query).replaceAll(replacementPattern);
}

@API(status = MAINTAINED)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experimental?

@nsmolenskii nsmolenskii changed the title add remove query filter [WIP]add remove query filter Oct 12, 2018
@nsmolenskii nsmolenskii changed the title [WIP]add remove query filter add remove query filter Oct 12, 2018
@whiskeysierra whiskeysierra merged commit dcd6eb1 into zalando:master Oct 15, 2018
@whiskeysierra
Copy link
Collaborator

Thanks for the contribution. I just released it as 1.11.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants