Update bill of materials (BOM) to define version for each dependency #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainermueller
requested review from
AlexanderYastrebov,
lukasniemeier-zalando and
whiskeysierra
as code owners
| @@ -20,30 +20,37 @@ | |||
| <dependency> | |||
| <groupId>org.zalando</groupId> | |||
| <artifactId>logbook-api</artifactId> | |||
| <version>1.12.0-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Is it possible to use a property pointing to it's own version? Otherwise we need to make sure to bump this here:
Line 11 in 936dedd
There was a problem hiding this comment.
Running mvn versions:set -D newVersion=1.12.0 locally just runs fine.
All dependencies in org.zalando:logbook-bom are updated to <version>1.12.0</version>
whiskeysierra
approved these changes
Nov 1, 2018
|
I released your fix as 1.11.1 to central. Thanks a lot for the contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To omit the versions in
pom.xmlthe dependencies inorg.zalando:logbook-bommust define<version>${logbook.version}</version>Motivation and Context
We still have to define the dependency version due to following error
[ERROR] 'dependencies.dependency.version' for org.zalando:logbook-servlet:jar is missing. @ com.inventage.demo:backend-war:[unknown-version]Types of changes
Checklist: