Chunking is now limited to the body itself #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whiskeysierra
requested review from
AlexanderYastrebov and
lukasniemeier-zalando
| public void write(final Correlation correlation, final HttpRequest request, final HttpResponse original) throws IOException { | ||
| chunk(original) | ||
| .map(chunk -> new BodyReplacementHttpResponse(original, chunk)) | ||
| .forEach(throwingConsumer(replaced -> delegate.write(correlation, request, replaced))); |
There was a problem hiding this comment.
What about going on step further and hide the headers, like
final Iterator<String> chunks = chunk(original).iterator();
final String firstChunk = chunks.next();
delegate.write(correlation, request, new BodyReplacementHttpResponse(original, firstChunk));
chunks.forEachRemaining(chunk -> delegate.write(correlation, request, new BodyReplacementHttpResponse(new HeaderHidingHttpResponse(original), chunk)));
There was a problem hiding this comment.
That would move it a bit closer to be a properly usable feature. Until now it was basically breaking our format, but even with my change it's still a gimmick and not 100% "production-ready".
As an example a parser wouldn't know that this is a chunk. I believe it would be nice to get attribute-support in (see #381) and use that to tag individual chunks with their number. Parsers like Scalyr could then exclude anything with $chunk > 1 when counting requests/responses (as an example).
lukasniemeier-zalando
approved these changes
Mar 4, 2019
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chunking used to work on the raw string that was the result of the formatting. This fix limits the impact of chunking to the body itself.
Motivation and Context
Fixes #322
Types of changes
Checklist: