Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for filtering request path #513

Merged
merged 4 commits into from
Jun 14, 2019

Conversation

skjolber
Copy link
Contributor

@skjolber skjolber commented May 20, 2019

Support for filtering the request path.

Description

Add PathFilter interface (much liker HeaderFilter and QueryFilter).

Motivation and Context

REST services often expose important values directly in their paths. Add support for filtering these.
Fixes #499

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@skjolber
Copy link
Contributor Author

skjolber commented Jun 5, 2019

Moved away from the regexp filter - was able to make a simple default filter which should be lightning fast. It accepts path expressions on the form /myApp/orders/{secret}/order, which are commonly found in frameworks like Spring REST (i.e. when using @PathVariable).

@whiskeysierra
Copy link
Collaborator

👍

@whiskeysierra whiskeysierra merged commit f190202 into zalando:master Jun 14, 2019
@skjolber skjolber deleted the pathFilter2 branch June 14, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for filtering path
2 participants