-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for filtering request path #513
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjolber
requested review from
AlexanderYastrebov,
lukasniemeier-zalando and
whiskeysierra
as code owners
May 20, 2019 14:12
skjolber
commented
May 27, 2019
Moved away from the regexp filter - was able to make a simple default filter which should be lightning fast. It accepts path expressions on the form |
logbook-core/src/main/java/org/zalando/logbook/FilteredHttpRequest.java
Outdated
Show resolved
Hide resolved
logbook-core/src/test/java/org/zalando/logbook/DefaultPathFilterTest.java
Show resolved
Hide resolved
logbook-core/src/test/java/org/zalando/logbook/DefaultPathFilterTest.java
Show resolved
Hide resolved
logbook-core/src/test/java/org/zalando/logbook/FilteredHttpRequestTest.java
Outdated
Show resolved
Hide resolved
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for filtering the request path.
Description
Add PathFilter interface (much liker HeaderFilter and QueryFilter).
Motivation and Context
REST services often expose important values directly in their paths. Add support for filtering these.
Fixes #499
Types of changes
Checklist: