Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about Spring Boot Starter dependency to README #545

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Add note about Spring Boot Starter dependency to README #545

merged 1 commit into from
Jun 28, 2019

Conversation

marcelstoer
Copy link
Contributor

Description

The README should mention to use the Spring Boot Starter dependency instead of the core dependency when working with Spring Boot.

Motivation and Context

To combat issues like this one #218 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@whiskeysierra
Copy link
Collaborator

👍

@whiskeysierra
Copy link
Collaborator

Thanks for the contribution!

@whiskeysierra whiskeysierra merged commit cc24afb into zalando:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderYastrebov AlexanderYastrebov Awaiting requested review from AlexanderYastrebov

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando

@whiskeysierra whiskeysierra Awaiting requested review from whiskeysierra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelstoer @whiskeysierra