Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed old code example in javadoc #711

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Fixed old code example in javadoc #711

merged 1 commit into from
Feb 12, 2020

Conversation

whiskeysierra
Copy link
Collaborator

@whiskeysierra whiskeysierra commented Feb 11, 2020 •
edited
Loading

Fixes #691

Description

Motivation and Context

Fixes #691

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@lukasniemeier-zalando
Copy link
Member

👍

@whiskeysierra whiskeysierra merged commit cb81a92 into master Feb 12, 2020
@whiskeysierra whiskeysierra deleted the bugfix/javadoc branch February 12, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderYastrebov AlexanderYastrebov Awaiting requested review from AlexanderYastrebov

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaDoc of JsonHttpLogFormatter isn't in line with method signatures
2 participants
@whiskeysierra @lukasniemeier-zalando