Externalize a handler to write json fields #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmveloso
requested review from
AlexanderYastrebov,
lukasniemeier-zalando and
whiskeysierra
as code owners
|
|
||
| private final JsonFactory factory; | ||
|
|
||
| private JsonFieldWriter delegate = this; // default to this implementation |
There was a problem hiding this comment.
By implementing this interface directly you're exposing that implementation detail to the outside world because FastJsonHttpLogFormatter is public. I'd hide that with a static inner class.
There was a problem hiding this comment.
Completely agree with that. In fact I was thinking that I should have followed that approach from the beginning.
| public String format( | ||
| final Precorrelation precorrelation, | ||
| final HttpRequest request) throws IOException { | ||
| public FastJsonHttpLogFormatter(final ObjectMapper mapper, |
There was a problem hiding this comment.
I guess this constructor is not covered by tests. If you follow my approach from above you get that for free, because you would actually use it then.
|
👍 |
|
I'm releasing this as 2.4.0 as we speak. Thanks for the contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to contribute with a custom JsonFieldWriter to have full freedom on how to write headers and body (naming and ordering).