Remove guava dependency #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #59 |
|
Ah! Ok... |
| @@ -70,7 +68,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| //@VisibleForTesting | |||
|
Almost scary how similar our code is 👻 |
|
👍 |
Closed
|
|
||
| Headers() { | ||
| public HeadersBuilder() { |
There was a problem hiding this comment.
Could be its own class now.
There was a problem hiding this comment.
I am thinking of implementing Header and Headers implements Iterable<Header> classes instead of map of lists as this will allow to extend it in future.
There was a problem hiding this comment.
But we need a map for easy lookups, e.g. in conditions.
| @@ -70,18 +71,18 @@ | |||
|
|
|||
| public static Predicate<RawHttpRequest> header(final String key, final String value) { | |||
| return request -> | |||
| request.getHeaders().containsEntry(key, value); | |||
| request.getHeaders().getOrDefault(key, Collections.emptyList()).contains(value); | |||
| } | |||
|
|
|||
| public static Predicate<RawHttpRequest> header(final String key, final Predicate<String> predicate) { | |||
| return request -> | |||
| request.getHeaders().get(key).stream().anyMatch(predicate); | |||
There was a problem hiding this comment.
This will throw an exception now if a key doesn't exist. Can you verify with a test?
|
👍 |
|
👍 nice collective effort |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like now everybody will do this)