Fix ClassNotFoundException when LogbookAutoConfiguration is processed

[jstanik]

To avoid ClassNotFoundException: javax.servlet.Filter a code referencing the Filter is moved to a static inner class which is processed only conditionally when javax.servlet.Filter is on the classpath.

Description

Factory method for creating FilterRegistrationBean moved from LogbookAutoConfiguration to conditionally processed class ServletFilterConfiguration.

Motivation and Context

Fixes issue #881

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.

[whiskeysierra]

I believe it's redundant now. Should be fine to remove those.

…

On Thu, 5 Nov 2020, 21:53 jstanik, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In logbook-spring-boot-autoconfigure/src/main/java/org/zalando/logbook/autoconfigure/LogbookAutoConfiguration.java <#882 (comment)>: > } @configuration(proxyBeanMethods = false) - @ConditionalOnClass(SecurityFilterChain.class) + @ConditionalOnClass({ SecurityFilterChain.class, Filter.class }) @ConditionalOnWebApplication I have added the web application type SERVLET to both the SecurityServletFilterConfiguration and ServletFilterConfiguration. Now I am not sure if keeping the condition @ConditionalOnClass(Filter.class) makes sense for these. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#882 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADI7HKW55PNCTBCRILSAYLSOMGFRANCNFSM4TKGH5AQ> .

[jstanik]

Ok, I removed those redundant conditions.

[whiskeysierra]

👍

[whiskeysierra]

I'm currently releasing this fix as 2.4.1. Thank you for your contribution! 🎉