Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds LogbookClientHttpRequestInterceptor for spring RestTemplate #917

Merged
merged 17 commits into from
Jan 13, 2021
Merged

adds LogbookClientHttpRequestInterceptor for spring RestTemplate #917

merged 17 commits into from
Jan 13, 2021

Conversation

nhomble
Copy link
Contributor

@nhomble nhomble commented Dec 27, 2020

Description

Creates a new ClientHttpRequestInterceptor that composes existing apache interceptor functionality but is more pluggable for spring users.

Motivation and Context

Spring RestTemplate users are typically abstracted away from HttpClient specific configurations. We operate at the RestTemplateBuilder level.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@nhomble nhomble changed the title adds LogbookClientHttpRequestInterceptor for spring RestTemplate adds LogbookClientHttpRequestInterceptor for spring RestTemplate Dec 27, 2020
@nhomble nhomble mentioned this pull request Dec 27, 2020
Closed
whiskeysierra
whiskeysierra reviewed Jan 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@whiskeysierra
Copy link
Collaborator

👍

@whiskeysierra whiskeysierra merged commit 215eb87 into zalando:main Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whiskeysierra whiskeysierra whiskeysierra left review comments

@AlexanderYastrebov AlexanderYastrebov Awaiting requested review from AlexanderYastrebov

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando lukasniemeier-zalando is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhomble @whiskeysierra