Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use system line separator #925

Merged
merged 2 commits into from
Jan 11, 2021
Merged

use system line separator #925

merged 2 commits into from
Jan 11, 2021

Conversation

nhomble
Copy link
Contributor

@nhomble nhomble commented Jan 6, 2021

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@@ -11,10 +11,10 @@
private final BodyFilter unit = new PrettyPrintingJsonBodyFilter();

/*language=JSON*/
Copy link
Collaborator

@whiskeysierra whiskeysierra Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this instead?

private final String pretty = Stream.of(
    "{",
    "  \"root\": {",
    "    \"child\": \"text\"",
    "  }",
    "}"
).collect(joining(System.lineSeparator()));

@whiskeysierra
Copy link
Collaborator

👍

@whiskeysierra whiskeysierra merged commit a6babcf into zalando:main Jan 11, 2021
@whiskeysierra
Copy link
Collaborator

Thank you for your contribution! 📣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants