capture response where servlet code programmatically starts async dispatch #985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GraphQL servlet from https://github.com/graphql-java-kickstart/graphql-java-servlet programmatically starts an async request by calling
startAsync
on theHttpServletRequest
. In this case, logbook misses the reply because the logbook filter checksrequest.isAsyncStarted()
before logging. In order to fix this issue, anAsyncListener
is being registered wheneverstartAsync
is being called.Regarding
LogbookAsyncListener
, would it make sense to also implement the other methods besidesonComplete
? If yes, how?Motivation and Context
Fix for issue #954
Types of changes
Checklist: