ARUHA-1604: added flushing collected events when reaching stream timeout #860
Conversation
Codecov Report
@@ Coverage Diff @@
## master #860 +/- ##
============================================
+ Coverage 53.56% 53.57% +0.01%
- Complexity 1691 1694 +3
============================================
Files 309 309
Lines 9359 9366 +7
Branches 841 843 +2
============================================
+ Hits 5013 5018 +5
- Misses 4046 4049 +3
+ Partials 300 299 -1
Continue to review full report at Codecov.
|
|
👍 |
|
deploy validation please |
3 similar comments
|
deploy validation please |
|
deploy validation please |
|
deploy validation please |
| @@ -101,6 +101,23 @@ public void whenStreamTimeoutReachedPossibleToCommit() throws Exception { | |||
| Assert.assertEquals(SC_NO_CONTENT, statusCode); | |||
| } | |||
|
|
|||
| @Test(timeout = 10000) | |||
| public void whenStreamTimeoutReachedThenEventsFlushed() throws Exception { | |||
There was a problem hiding this comment.
I tested streaming using this same parameter in the old stack and the new one and both behave the same way. Both got 2 batches, one containing 3 events and the other with debug message. Does this test actually exercise or prove that the fix works?
There was a problem hiding this comment.
I remember that I was running this test against the old version and it failed. I will check it again now.
There was a problem hiding this comment.
Oh yes, sorry, I remembered now. I changed the test later and it actually now works for old version as well (as it reaches max_uncommitted_events)
I now changed the test. It will now fail in old version and will work for new version.
|
👍 |
…-stream-timeout # Conflicts: # CHANGELOG.md
|
👍 |
1 similar comment
|
👍 |
Added flushing collected events when reaching stream timeout in subscription API
Description
When stream_timeout is reached user wants to get events which were collected so far.
Review
Deployment Notes
We should keep an eye on complaining users