This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
aruha-1636: unlimited retention time by Nakadi admin #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
=========================================
Coverage 53.42% 53.42%
Complexity 1695 1695
=========================================
Files 309 310 +1
Lines 9398 9398
Branches 845 845
=========================================
Hits 5021 5021
Misses 4077 4077
Partials 300 300
Continue to review full report at Codecov.
|
rcillo
reviewed
May 4, 2018
|
|
||
| Mockito.verify(mockedErrors, Mockito.times(0)).rejectValue(Matchers.any(), Matchers.any(), | ||
| Matchers.any()); | ||
| validator.checkRetentionTime(eventTypeOptions); |
There was a problem hiding this comment.
What is this test testing? Maybe just remove it completely?
|
👍 |
|
deploy validation please |
2 similar comments
|
deploy validation please |
|
deploy validation please |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Description
Allow Nakadi admin set unlimited retention time