Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

ARUHA-1997: Extended the catched exception range; #974

Merged
merged 3 commits into from
Nov 13, 2018
Merged

Conversation

v-stepanov
Copy link
Contributor

One-line summary

Zalando ticket : ARUHA-1997

Description

For some reason (probably because of migrating to Hikari) in most cases we now have a different exception thrown when user tries to create ET that already exists. This is a fix for that problem.

Review

  • Tests
  • Documentation

@lmontrieux
Copy link
Contributor

👍

1 similar comment
@v-stepanov
Copy link
Contributor Author

👍

@codecov-io
Copy link

codecov-io commented Nov 1, 2018

Codecov Report

Merging #974 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #974      +/-   ##
============================================
+ Coverage     54.12%   54.18%   +0.05%     
- Complexity     1776     1778       +2     
============================================
  Files           335      335              
  Lines          9592     9592              
  Branches        882      882              
============================================
+ Hits           5192     5197       +5     
+ Misses         4079     4076       -3     
+ Partials        321      319       -2
Impacted Files Coverage Δ Complexity Δ
...do/nakadi/repository/db/EventTypeDbRepository.java 4.34% <0%> (ø) 1 <0> (ø) ⬇️
...n/java/org/zalando/nakadi/service/EventStream.java 74.79% <0%> (+1.62%) 30% <0%> (+1%) ⬆️
...zalando/nakadi/service/job/TimelineCleanupJob.java 67.85% <0%> (+5.35%) 10% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0779692...e3585db. Read the comment docs.

@v-stepanov
Copy link
Contributor Author

👍

2 similar comments
@v-stepanov
Copy link
Contributor Author

👍

@lmontrieux
Copy link
Contributor

👍

@adyach
Copy link
Member

adyach commented Nov 7, 2018

deploy validation please

@adyach
Copy link
Member

adyach commented Nov 7, 2018

👍

@v-stepanov
Copy link
Contributor Author

👍

1 similar comment
@lmontrieux
Copy link
Contributor

👍

@v-stepanov v-stepanov merged commit 92bb248 into master Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants