Fix the casing of github.com/Sirupsen/logrus to match what the project itself uses #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t itself uses. Dep enforces this.
coderanger
requested review from
alexeyklyukin,
avaczi,
CyberDem0n,
erthalion,
Jan-M and
sdudoladov
as code owners
sdudoladov
approved these changes
Sep 5, 2018
There was a problem hiding this comment.
Reference https://github.com/sirupsen/logrus/blob/master/example_basic_test.go#L4 or the default name capitalization in github to confirm I'm not off the mark?
actually both capitalizations work for me but I like uniform things :)
alexeyklyukin
approved these changes
Sep 5, 2018
|
This was apparently a whole big thing back in 2017 sirupsen/logrus#553 (comment) sirupsen/logrus#570 (comment) and I just never noticed until I happened to pull in both postgres-operator and another lib that uses logrus. Apparently lowercase is the Official Solution™ even though it can make your glide cache cranky. |
|
this made glide.lock hash incorrect :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dep enforces this. I have no idea why it just started bothering me about it but it seemed like a safe thing to fix. Reference https://github.com/sirupsen/logrus/blob/master/example_basic_test.go#L4 or the default name capitalization in github to confirm I'm not off the mark?