Add instructions when existing ControllerAdvice and update config path #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a section in the Spring MVC installation README.md regarding the situation when there is an existing ControllerAdvice. Additionally I've updated the application.properties config path which was outdated. This PR refers to an issue I've opened some time back - zalando#777
echoesbr
requested review from
whiskeysierra and
lukasniemeier-zalando
as code owners
|
Hi @whiskeysierra @lukasniemeier, |
|
Thanks for the PR. I bundled it into one to incorporate two suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a section in the Spring MVC installation README.md regarding the situation when there is an existing ControllerAdvice. Additionally I've updated the application.properties config path which was outdated.
This PR refers to an issue I've opened some time back - #777
Motivation and Context
Many existing applications already use a ControllerAdvice and it's quite easy to forget about it. The motivation for this PR came from facing this problem myself.
Types of changes
Checklist: